Skip to content

Fix better_villagers worker rooms never generating (Forge/1.20.1) - #7

Open
0-bingci wants to merge 2 commits into
Reggarfgod:Forge/1.20.1from
0-bingci:fix/better-villagers-workers
Open

Fix better_villagers worker rooms never generating (Forge/1.20.1)#7
0-bingci wants to merge 2 commits into
Reggarfgod:Forge/1.20.1from
0-bingci:fix/better-villagers-workers

Conversation

@0-bingci

@0-bingci 0-bingci commented Aug 1, 2026

Copy link
Copy Markdown
Fixes #6

The Create-themed worker rooms (andesite/brass/copper) shipped in 1.5.7 could never
generate. This PR contains the JSON-side fixes:

- Corrected the three structure `location` paths in the better_villagers pools:
  `addons/better_villager/...` -> `addons/better_villagers/...` (the actual NBT location)
- Added the three worker rooms to `stoneholm:point_of_interest` and
  `stoneholm:abandoned_point_of_interest` at weight 30 (same tier as copper_shop /
  libraries), since nothing referenced the addon pools before

Not covered here (needs re-saving structures in-game, see the issue):
- `stoneholm:villager` / `stoneholm:iron_golm` misspellings inside bedroom NBT jigsaws

Tested locally on 1.20.1 Forge: with these changes the worker rooms generate correctly,
including chests and their loot tables.

0-bingci and others added 2 commits August 1, 2026 19:17
…ter_villagers

The pool elements pointed to stoneholm:addons/better_villager/poi/* (singular),
but the structure NBTs live under addons/better_villagers/ (plural), so the
templates silently resolved to empty.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The better_villagers POI pools were not referenced by any jigsaw or pool, so
the andesite/brass/copper worker rooms could never generate. Wire them into
stoneholm:point_of_interest and stoneholm:abandoned_point_of_interest at
weight 30 (same tier as copper_shop/libraries).

Fixes the generation half of issue Reggarfgod#6.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant