Added exception tag for mapmaker#19
Open
crux-f wants to merge 2 commits into
Open
Conversation
- Checks if villager has scoreboard tag "cvt_trade_override"; If so, uses the vanilla trades regardless of disabled professions list - Allows villagers with predetermined trades in nbt to function as expected in custom map / server scenarios - Custom (NBT) trades are still removed at present if !plugin.isVanillaTradesAllowed(); Leaving it to Reldeam's discretion as to how that interacts
- Checks if villager has scoreboard tag "cvt_trade_override"; If so, uses the vanilla trades regardless of disabled professions list - Allows villagers with predetermined trades in nbt to function as expected in custom map / server scenarios - Custom (NBT) trades are still removed at present if !plugin.isVanillaTradesAllowed(); Leaving it to Reldeam's discretion as to how that interacts
Author
|
Note: I will be implementing this fork on my server and will let you know if I run into any issues, but as far as I can tell from looking over the plugin this shouldn't break anything major. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm no Github expert, so forgive me if this is a little messy;
Decided to save you some time and add the enhancement myself! My Java is a little rusty, but I got there in the end.
(Closes #16 )