Add new analyzer for unused results - #13
Open
pobiega wants to merge 1 commit into
Open
Conversation
Contributor
|
Looks good! |
|
What about adding the warnings to not used IResult as well? |
Member
|
I agree with both @Foxtrek64 and @Rutherther here, otherwise things look good. Happy to merge if you fix/add those two things. |
Member
|
What's the status of this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6
As demonstrated by the unittests, it should raise diagnostics warnings for unused results returned from called methods. Tried following the remora code style, but feel free to adjust anything you find out of line.
Also feel free to reach out on the C# discord if there is anything you wish to discuss about this.