Read lwjgl3 LWJGL version/natives from the root project explicitly#135
Merged
Conversation
Gradle 9.6 deprecated implicit lookup of properties in parent projects (it becomes a hard error in Gradle 10). The two lwjgl3 modules pulled lwjglVersion/lwjglNatives via project.findProperty(...), which silently walked up to the root project's extra properties. Read them from rootProject.extra[...] directly instead. Verified on Gradle 9.6.0: no deprecation warnings, and the lwjgl dependencies still resolve to 3.3.3. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBoth LWJGL Gradle build scripts now read ChangesLWJGL Gradle property sourcing
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle 9.6 deprecated implicit lookup of properties in parent projects (it becomes a hard error in Gradle 10). The
ardor3d-lwjgl3andardor3d-lwjgl3-nuklearmodules readlwjglVersion/lwjglNativesviaproject.findProperty(...), which resolved them by walking up to the root project'sextraproperties — the deprecated path. They now readrootProject.extra[...]directly.Surfaced by the Gradle 9.6 bump in #134; the awt/swt lwjgl3 modules were never affected (they carry their own versions).
Verified on Gradle 9.6.0:
./gradlew help --warning-mode allreports zero deprecations, and:ardor3d-lwjgl3:dependenciesstill resolvesorg.lwjgl:lwjgl:3.3.3.🤖 Generated with Claude Code
Summary by CodeRabbit