Skip to content

Read lwjgl3 LWJGL version/natives from the root project explicitly#135

Merged
Renanse merged 1 commit into
masterfrom
lwjgl3-explicit-root-properties
Jun 26, 2026
Merged

Read lwjgl3 LWJGL version/natives from the root project explicitly#135
Renanse merged 1 commit into
masterfrom
lwjgl3-explicit-root-properties

Conversation

@Renanse

@Renanse Renanse commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Gradle 9.6 deprecated implicit lookup of properties in parent projects (it becomes a hard error in Gradle 10). The ardor3d-lwjgl3 and ardor3d-lwjgl3-nuklear modules read lwjglVersion/lwjglNatives via project.findProperty(...), which resolved them by walking up to the root project's extra properties — the deprecated path. They now read rootProject.extra[...] directly.

Surfaced by the Gradle 9.6 bump in #134; the awt/swt lwjgl3 modules were never affected (they carry their own versions).

Verified on Gradle 9.6.0: ./gradlew help --warning-mode all reports zero deprecations, and :ardor3d-lwjgl3:dependencies still resolves org.lwjgl:lwjgl:3.3.3.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Standardized how shared library version and native settings are read during the build, using root-level configuration values for more consistent dependency resolution.

Gradle 9.6 deprecated implicit lookup of properties in parent projects
(it becomes a hard error in Gradle 10). The two lwjgl3 modules pulled
lwjglVersion/lwjglNatives via project.findProperty(...), which silently
walked up to the root project's extra properties. Read them from
rootProject.extra[...] directly instead.

Verified on Gradle 9.6.0: no deprecation warnings, and the lwjgl
dependencies still resolve to 3.3.3.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1bc9b11b-4977-4108-9b57-2e4b211737e7

📥 Commits

Reviewing files that changed from the base of the PR and between 0814985 and d5d46b2.

📒 Files selected for processing (2)
  • ardor3d-lwjgl3-nuklear/build.gradle.kts
  • ardor3d-lwjgl3/build.gradle.kts

📝 Walkthrough

Walkthrough

Both LWJGL Gradle build scripts now read lwjglVersion and lwjglNatives from rootProject.extra as non-null strings instead of project.findProperty(...).

Changes

LWJGL Gradle property sourcing

Layer / File(s) Summary
Root extra lookup
ardor3d-lwjgl3/build.gradle.kts, ardor3d-lwjgl3-nuklear/build.gradle.kts
Both build scripts cast lwjglVersion and lwjglNatives from rootProject.extra and keep their dependency usage unchanged.

🎯 1 (Trivial) | ⏱️ ~3 minutes

A bunny hops through the build,
🌿 extra roots now hold the field.
Two scripts nibble strings so bright,
LWJGL paths feel clean and light.
Hop, hop, build! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: sourcing LWJGL version and natives from the root project explicitly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lwjgl3-explicit-root-properties

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Renanse Renanse merged commit 3edc60c into master Jun 26, 2026
2 checks passed
@Renanse Renanse deleted the lwjgl3-explicit-root-properties branch June 26, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant