Skip to content

Normalize gradlew.bat back to LF in the repository#136

Merged
Renanse merged 1 commit into
masterfrom
fix-gradlew-bat-line-endings
Jun 26, 2026
Merged

Normalize gradlew.bat back to LF in the repository#136
Renanse merged 1 commit into
masterfrom
fix-gradlew-bat-line-endings

Conversation

@Renanse

@Renanse Renanse commented Jun 26, 2026

Copy link
Copy Markdown
Owner

The gradle-wrapper bump in #134 committed gradlew.bat with CRLF baked into the blob, which contradicts .gitattributes:

gradlew.bat text eol=crlf

That attribute means the stored blob must be LF and is smudged to CRLF on checkout. With CRLF in the blob, git's clean filter normalizes the working copy back to LF, compares it against the CRLF blob, and reports a permanent phantom "modified" — the same breakage #128 ("pin Gradle wrapper line endings") had already fixed. On Windows/WSL checkouts this can wedge git stash/rebase.

This re-normalizes the blob to LF via git add --renormalize gradlew.bat. No functional change — the file still checks out as CRLF on Windows; only the stored representation changes.

Before: git cat-file blob origin/master:gradlew.bat | grep -c $'\r' → 82
After: → 0

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Normalized formatting and line endings in the Windows Gradle wrapper script.
    • No functional changes to how the wrapper finds Java or launches Gradle.

The gradle-wrapper bump in #134 committed gradlew.bat with CRLF baked
into the blob, contradicting .gitattributes (gradlew.bat text eol=crlf,
so the stored blob must be LF and is smudged to CRLF on checkout). That
reintroduced the perpetual phantom "modified" diff that #128 had fixed,
and it can wedge stash/rebase on Windows/WSL checkouts.

Re-normalized via `git add --renormalize gradlew.bat`; the file still
checks out as CRLF, only the stored blob changes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 38ecdf9f-a6b9-4a58-bab4-508ceebcccf8

📥 Commits

Reviewing files that changed from the base of the PR and between 0814985 and c306b19.

📒 Files selected for processing (1)
  • gradlew.bat

📝 Walkthrough

Walkthrough

The Windows Gradle wrapper batch file was reformatted and normalized for whitespace and line endings, while preserving the existing Java lookup, wrapper invocation, and exit handling flow.

Changes

Windows wrapper formatting

Layer / File(s) Summary
Batch wrapper normalization
gradlew.bat
The file was rewritten with formatting and line-ending normalization, with the same JAVA_HOME/java.exe resolution, wrapper JAR launch, and error handling flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Renanse/Ardor3D#128: Also updates gradlew.bat with formatting and line-ending normalization while leaving the wrapper startup logic unchanged.

Poem

A bunny hops through tidy lines,
The wrapper file now shines and aligns.
Java still leaps, the jar still sings,
Through whitespace fluff and little things.
🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: renormalizing gradlew.bat in the repository to LF line endings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-gradlew-bat-line-endings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Renanse Renanse merged commit 50bef6c into master Jun 26, 2026
2 checks passed
@Renanse Renanse deleted the fix-gradlew-bat-line-endings branch June 26, 2026 23:06
@Renanse Renanse restored the fix-gradlew-bat-line-endings branch June 26, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant