Normalize gradlew.bat back to LF in the repository#136
Conversation
The gradle-wrapper bump in #134 committed gradlew.bat with CRLF baked into the blob, contradicting .gitattributes (gradlew.bat text eol=crlf, so the stored blob must be LF and is smudged to CRLF on checkout). That reintroduced the perpetual phantom "modified" diff that #128 had fixed, and it can wedge stash/rebase on Windows/WSL checkouts. Re-normalized via `git add --renormalize gradlew.bat`; the file still checks out as CRLF, only the stored blob changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Windows Gradle wrapper batch file was reformatted and normalized for whitespace and line endings, while preserving the existing Java lookup, wrapper invocation, and exit handling flow. ChangesWindows wrapper formatting
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The gradle-wrapper bump in #134 committed
gradlew.batwith CRLF baked into the blob, which contradicts.gitattributes:That attribute means the stored blob must be LF and is smudged to CRLF on checkout. With CRLF in the blob, git's clean filter normalizes the working copy back to LF, compares it against the CRLF blob, and reports a permanent phantom "modified" — the same breakage #128 ("pin Gradle wrapper line endings") had already fixed. On Windows/WSL checkouts this can wedge
git stash/rebase.This re-normalizes the blob to LF via
git add --renormalize gradlew.bat. No functional change — the file still checks out as CRLF on Windows; only the stored representation changes.Before:
git cat-file blob origin/master:gradlew.bat | grep -c $'\r'→ 82After: → 0
🤖 Generated with Claude Code
Summary by CodeRabbit