UI improvements - #150
Open
therealhoodboy wants to merge 30 commits into
Open
Conversation
Collaborator
Author
|
Re-opened pull request, please share any opinion regarding the design changes |
Resaki1
requested changes
May 25, 2024
Resaki1
left a comment
Resaki1
left a comment
Owner
There was a problem hiding this comment.
Good ideas, thanks! just some code styling issues
Added support for light- and darkmode
Resaki1
requested changes
Sep 10, 2024
added 13 commits
September 11, 2024 17:10
Fix transition for RessourceMenu
Resaki1
requested changes
Sep 16, 2024
Resaki1
left a comment
Resaki1
left a comment
Owner
There was a problem hiding this comment.
Nice work so far! Just some things to change
Also, on desktop the menus look kinda weird
Comment on lines
-100
to
+136
| state.addRessources(BuildingSellBenefits[state.buildings[x][y]]); | ||
| const sellBenefits = BuildingSellBenefits[building]; | ||
| const ressourcesToAdd = Object.fromEntries( | ||
| Object.entries(sellBenefits).map(([key, value]) => [key, value]) | ||
| ); | ||
| state.addRessources(ressourcesToAdd); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.