build: compile the backend-independent libraries for x64 as well - #23
Merged
Merged
Conversation
utils, contract, core and js hold no game-version-specific code, so nothing in them needs a 32-bit host. Giving them x64 configurations keeps that property honest - a Win32 assumption that creeps in stops compiling rather than waiting for a second backend to find it. The project configurations drop |Platform from their conditions so one set covers both, the .slnx maps lod114d, the glue DLL and the tests to Win32 only, and build.ps1 takes -Platform. CI builds both. Two Win32 assumptions this turned up: AppConfig sized its limits from int literals that overflow differently under LP64 rules, and Pathfinder compared a uint32_t against a size_t. The 1.14d backend, its glue and the tests stay Win32 - the game is 32-bit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils,contract,coreandjshold no game-version-specific code, so nothing in them needs a 32-bit host. Giving them x64 configurations keeps that property honest — a Win32 assumption that creeps in stops compiling now, rather than waiting for a second backend to find it.What changed
|Platformfrom their configuration conditions, so one set of settings covers both platforms.d2bsng.slnxmapslod114d, the glue DLL and the tests to Win32 only, so an x64 solution build skips them rather than failing.build.ps1takes-Platform Win32|x64(Win32 stays the default).Two Win32 assumptions this turned up
AppConfigsized its limits fromintliterals (100 * 1024 * 1024), which is fine at 32-bit but relies on the wrong type under LP64 rules. Nowsize_t{100} * 1024 * 1024.Pathfindercompared auint32_tagainst asize_tinstd::min.Both are real portability bugs rather than cosmetic warnings.
Scope
The 1.14d backend, its glue and the tests stay Win32 — the game is 32-bit and that is not changing. Nothing links at x64; these are static libraries only, so this is a compile-coverage change, not a new shippable artifact.
Verification
clang-format clean; clang-tidy clean (118 files, full no-cache run). The x64 build itself has not been run by me — that is the thing worth checking on review.
First of five PRs splitting up what was previously one large branch. The rest follow in order: named loggers, the Detours slot API, launch-option scrubbing, and moving the input hook and proxy into
core.🤖 Generated with Claude Code