WR-18426: mark Payments.API as type api - #21
Merged
Merged
Conversation
Without type=api the pipeline's component discovery set hasAPIs=false, so PublishToECR/TagECRImage were skipped, the image was never pushed, and the ECR repo was never created.
DustinK-retailsuccess
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wayroo.Payments.APIwas missing"type": "api"incomponents.json. Pipeline component discovery counts a component as an API only whentype == "api", sohasAPIswas false —PublishToECRandTagECRImagewere skipped, the container image was never built/pushed, and thewayroo.paymentsECR repo was never created.deploy-cdkstill ran and stood up an ECS service pointing at a non-existent image, failing the pull.Changes
components.json: add"type": "api"toWayroo.Payments.API(matchesWayroo.ContentLibrary.APIand every other component).