[WIP] Add trigger explain button#1313
Merged
Jamiras merged 18 commits intoMay 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a button to the asset editor that opens a dialog which attempts to display the logic using code note information.
This PR adds the basic functionality of single condition comparisons. Future PRs will expand upon that for more advanced logic.
If the logic contains any delta+mem conditions for the same address, they'll be segregated from the other conditions.
If the logic doesn't contain and delta+mem conditions, everything is grouped together.
If there's a captured hit, the capture and reset conditions are listed separately.
Logic in alts is only visible when the alt is selected. I don't know if there's a good way to roll those into the view (and if there is, it will be handled in a later PR).