feat(GameScreenshotsRelationManager): adjust copy for systems that support upscaling#4905
Merged
wescopeland merged 2 commits intoMay 21, 2026
Conversation
Jamiras
approved these changes
May 21, 2026
wescopeland
added a commit
that referenced
this pull request
May 21, 2026
…4906) Accompanies #4905. This PR adjusts the validation copy in the player-facing screenshot upload dialog. The empty state is a bit calmer now, and there are multiple 2x/3x nudges for systems that support upscaling. Supported resolutions are no longer shown unless there's very few of them (most systems) or there's a validation error. These changes are entirely centered around the labels that users see. Functionally, the dialog behaves the same. **Empty States** <img width="459" height="431" alt="Empty Simple" src="https://github.com/user-attachments/assets/6f282625-d697-4e42-bf43-de21ddcac22a" /> <img width="476" height="464" alt="Empty Upscaling" src="https://github.com/user-attachments/assets/ffaa5df8-7da4-4808-81e7-c23c726d1ec5" /> --- **Upscaling Warning** <img width="467" height="559" alt="1x Warning" src="https://github.com/user-attachments/assets/e39e372c-3094-42da-b3ab-64e0198e9e2f" /> --- **Validation Errors** <img width="469" height="585" alt="Invalid Error without Upscaling" src="https://github.com/user-attachments/assets/a5b13d0a-c82a-4f2c-8103-7f3167e69fe5" /> <img width="470" height="578" alt="Invalid Error with Upscaling" src="https://github.com/user-attachments/assets/34133c39-5ae8-44d1-a7b3-4da1d34220b0" /> <img width="338" height="145" alt="Invalid Resolution Tooltip" src="https://github.com/user-attachments/assets/3b3cb14f-601e-4e3f-82f6-517785bf2f55" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly adjusts the helper text for the screenshot upload when the game's system supports upscaling. Now, the helper text nudges the user towards uploading an upscaled screenshot. A similar change will be needed in the player-facing dialog.
Before
After
