Skip to content

fix: prevent self-referential EventAchievement infinite loops #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wescopeland wants to merge 4 commits into
base: master
Choose a base branch
from
+12 −0
Open

fix: prevent self-referential EventAchievement infinite loops #4908

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21280a6
fix: prevent self-referential EventAchievement infinite loops
wescopeland May 20, 2026
7ee2bd7
Merge branch 'master' into event-ach-inf-loop-fix
wescopeland May 20, 2026
95094e2
fix: address feedback
wescopeland May 21, 2026
3a2bc4b
chore: missing change
wescopeland May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/Filament/Resources/EventAchievementResource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use App\Models\EventAchievement;
use App\Models\Game;
use App\Models\User;
use Closure;
use Filament\Forms;
use Filament\Infolists;
use Filament\Pages\Page;
Expand Down Expand Up @@ -167,6 +168,17 @@ public static function form(Schema $schema): Schema
}

return $label;
})
->rule(function (): Closure {
return function (string $attribute, mixed $value, Closure $fail): void {
if ($value === null) {
return;
}

if (EventAchievement::where('achievement_id', (int) $value)->exists()) {
$fail('Source achievement cannot be an event achievement.');
}
};
Copy link
Copy Markdown
Member

@Jamiras Jamiras May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we ever want to allow any event achievement to depend on another event achievement? Should the restriction just be "source achievement cannot be event achievement"?

Otherwise, we could still end up with an infinite loop if any achievement in the chain pointed back to the start node: A -> B -> C -> A

Copy link
Copy Markdown
Member Author

@wescopeland wescopeland May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

I've reverted most of the original implementation in latest (let's just treat it as a data issue if it happens in prod somehow) and tightened this rule.

}),

Forms\Components\DatePicker::make('active_from')
Expand Down
Loading