chore: adjust game screenshot limits#4909
Merged
wescopeland merged 4 commits intoMay 21, 2026
Merged
Conversation
Jamiras
approved these changes
May 21, 2026
| return new HtmlString( | ||
| $subjectLine | ||
| . self::buildApproveExplanation('This game already has 20 in-game screenshots approved. (20 max)') | ||
| . self::buildApproveExplanation("This game already has {$cap} in-game screenshots approved. ({$cap} max)") |
Member
There was a problem hiding this comment.
Should the first placeholder use $approvedCount?
Member
Author
There was a problem hiding this comment.
Good catch, I think it should. Updated.
| { | ||
| return match ($this) { | ||
| self::Title, self::Completion => 1, | ||
| self::Ingame => 10, |
Member
There was a problem hiding this comment.
Unrelated: Why wasn't this InGame?
Member
Author
There was a problem hiding this comment.
Mirrors the schema for consistency (but not a hard opinion, we can change it):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few minor adjustments to game screenshot caps and demotion logic:
Replacedinstead ofPending, which better aligns with the behavior of the moderation tool.10 games already have more than 10 screenshots. Those will continue to behave as they do today, but they won't support more screenshots being added to them.