Skip to content

fix: asset issuer display helper, reduced-motion, and Freighter timeout/retry - #208

Open
mallison031 wants to merge 4 commits into
RevenantLabs:mainfrom
mallison031:fix/issue-23-36-63
Open

mallison031 wants to merge 4 commits into
RevenantLabs:mainfrom
mallison031:fix/issue-23-36-63

Conversation

@mallison031

@mallison031 mallison031 commented Jul 28, 2026 •

Copy link
Copy Markdown

#Closes #23
#Closes #36
#Closes #63

Summary

Addresses three contributor issues in one focused PR.

Closes #23 — Asset issuer display helper

  • Enhanced TrustlineCheck to return assetCode and issuer alongside the existing result
  • Added a copyable asset identity card to the Trustline Checker page, showing the checked asset code and a truncated/copyable issuer address via CopyableValue
  • The Balance Viewer already displayed issuers with CopyableValue through BalanceList

Closes #36 — Respect reduced-motion preferences

  • Added @media (prefers-reduced-motion: reduce) to globals.css
  • Uses the established 0.01ms pattern (not 0s) to prevent animationend event firing
  • Disables decorative body pseudo-element animations explicitly
  • Default visual experience is unchanged for users without the preference

Closes #63 — Freighter connection timeout and retry

  • Added a 15-second client-side timeout via Promise.race
  • Added connecting state with button disable and loading text
  • Added connectionId ref to prevent stale responses from overwriting newer state
  • Distinct states for timeout, user rejection, and missing extension
  • Retry is safe: button re-enables after any failure and starts a fresh attempt

Validation

  • npm run lint — passes
  • npx tsc --noEmit — passes
  • npm run build — passes, all routes compile
  • Tests: pre-existing rolldown binding issue in CI environment (unrelated to changes)

Files changed

File Change
lib/stellar/trustline.ts Added assetCode and issuer to TrustlineCheck
app/tools/trustline-checker/page.tsx Added copyable asset identity card with CopyableValue
app/globals.css Added prefers-reduced-motion: reduce media query
app/tools/freighter-connect/page.tsx Added timeout, connecting state, and stale-response guard

…er timeout/retry (closes #23, closes #36, closes #63)
@drips-wave

drips-wave Bot commented Jul 28, 2026

Copy link
Copy Markdown

@mallison031 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mallison031

Copy link
Copy Markdown
Author

@egekoca pls review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant