Repository navigation
Conversation
…dx#449) Add a slider and choice option to adjust the volume level of the Sheikah Slate shrine/item sensor beeps from 0% to 100% (default 100%), with 0% muting the sensor completely. - Parse BARS container and patch AMTA/BWAV for Sys_Item_SheikSensor on mount in runtime/services/fs.c and dynamically in runtime/shrine_sensor.c - Add shrine_sensor_volume to Settings, with persistence and control socket support - Add UI controls to in-game Options (P_AUDIO) and standalone launcher Audio tab - Add translations across all 13 supported languages in runtime/ui/i18n/ - Add test coverage in tests/test_shrine_sensor.c and Makefile target test-shrine-sensor
Revivedx
added a commit
that referenced
this pull request
Nov 8, 2026
New: - Audio > Audio output: Stereo, Surround 5.1 or 3D Headphones. Stereo stays the default (#576). - Audio > Shrine sensor volume, 0% to 100%, from the next start (#571, fixes #449). The sound is changed in memory only; the game files are not touched. - Controls > HUD button layout: where A, B, X and Y sit on the HUD's diamond, from the next start. Automatic follows the controller bindings (#574, #321). Tested by playing on Windows with headphones (Stereo and 3D Headphones), and with a hidden start, warp and teleport run: no crash and no errors in the log. Surround 5.1 has not been tested on real 5.1 speakers, and the option says so. Co-authored-by: jfpaardoo <juaparpar@alum.us.es> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks, this is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #449
Adds an option and slider to configure the Sheikah Slate shrine and item sensor beeping volume level from 0% to 100% (default 100%), with 0% completely muting the sensor beeps:
Sound/Resource/M_UI.barsinsidePack/Bootup.pack(or loose in RomFS) on RomFS mount.Sys_Item_SheikSensor(AMTA metadata and BWAV sound data).orig_db + 20.0f * log10f(pct / 100.0f)).-999.0fdB and zeroes the raw 16-bit PCM sample data in the BWAV payload for an absolute silence guarantee.shrine_sensor_volume(0-100) toSettings, with full persistence in settings file and live control socket exposure.shrine_sensor_apply().P_AUDIOpage, Off / 10% .. 100%).Audiotab slider).runtime/ui/i18n/*.inc.tests/test_shrine_sensor.cand a newMakefiletargettest-shrine-sensor.How it was tested
make test-shrine-sensor: Validated BARS parsing, 100% level preservation, 50% attenuation (-6.02 dB), 0% mute (-999.0 dB and sample data zeroing), and runtimeshrine_sensor_apply().python tools/i18n_check.py: Passed with 0 missing and 0 unused strings across all 13 languages.make test-pc-controls: Verified settings persistence and controls integrity.make runtime-objs: Clean compile of all runtime objects without errors or warnings.git diff --check: 0 whitespace/formatting errors.Checklist
testand opened againsttest