Repository navigation
Conversation
Open
Revivedx
added a commit
that referenced
this pull request
Nov 8, 2026
New: - Audio > Audio output: Stereo, Surround 5.1 or 3D Headphones. Stereo stays the default (#576). - Audio > Shrine sensor volume, 0% to 100%, from the next start (#571, fixes #449). The sound is changed in memory only; the game files are not touched. - Controls > HUD button layout: where A, B, X and Y sit on the HUD's diamond, from the next start. Automatic follows the controller bindings (#574, #321). Tested by playing on Windows with headphones (Stereo and 3D Headphones), and with a hidden start, warp and teleport run: no crash and no errors in the log. Surround 5.1 has not been tested on real 5.1 speakers, and the option says so. Co-authored-by: jfpaardoo <juaparpar@alum.us.es> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks, this is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
settings.ini, and the control socket (audio_output = stereo | surround_51 | headphones_3d):audio_output = stereo/0), keeping default behavior untouched.FL, FR, FC, LFE, BL, BR) passed directly to SDL3 (audio_output = surround_51/1).audio_output = headphones_3d/2) implementing interaural time difference (ITD) delay lines, head-shadow low-pass filtering, rear pinna high-shelf filtering, center-channel early reflection, LFE ~120 Hz low-pass filtering, and a soft-knee limiter.IAudioDevice::GetActiveChannelCount(cmd 5) andGetActiveChannelCountAuto(cmd 13) inruntime/services/audio.cto report 6 active channels when Surround 5.1 or 3D Headphones is selected, so the game'snn::audioengine renders discrete 6-channel audio.IAudioDevicesystem events (cmd 4,11,12) on runtime mode changes and dynamically re-opens the SDL audio output stream when switching between 2-channel and 6-channel modes.runtime/ui/i18n/*.incfiles and synthetic unit tests intests/test_audio_mix.c.Fixes #573
How it was tested
make test-audio-mix: PASS (verifies channel counts, ITU 5.1 downmixing, 5.1 pass-through channel ordering, 3D binaural ITD delays, head-shadow filter, LFE low-pass filter, and soft limiter).make test-pc-controls: PASS (verifiesaudio_outputsettings persistence and clamping).python3 tools/i18n_check.py: PASS (0 missing, 0 unused across all 13 locales).git diff --check: clean (no whitespace or formatting errors).make -j8on Windows (MSYS2 UCRT64, clang): builds cleanly with zero warnings.Checklist
testand opened againsttest