test: cover concentration enforcement boundaries and testnet bypass#388
Merged
thlpkee20-wq merged 3 commits intoMay 27, 2026
Merged
Conversation
|
@ayo-ola0710 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Enforcement Boundaries: Added explicit comments in the report_revenue function to clarify that concentration is allowed when current <= max_bps and rejected only when current > max_bps.
Testnet Bypass: Documented the testnet-mode bypass logic in report_revenue, explaining that enforcement is skipped to allow for flexible integration testing.
Security Guardrails :
Verification Results
Compilation: Verified that the project compiles successfully using cargo check --tests.
Code Integrity: Ensured all changes match the existing coding style and maintain the contract's security invariants.
Close #367