test: assert atomic rollback on cross-contract transfer failure (#378)#399
Merged
thlpkee20-wq merged 2 commits intoMay 31, 2026
Conversation
…raOrg#378) Add claim flow transfer failure tests to the cross-contract atomicity suite. - Add FailingTransferToken mock contract: implements full Soroban token interface, panics when transfer is called with from==fail_from. This allows deposit (issuer→contract) to succeed while claim (contract→holder) fails, isolating the claim transfer failure path. - Add 7 tests in src/test_claim_transfer_fail.rs: - claim_transfer_fail_returns_transfer_failed - claim_transfer_fail_does_not_advance_last_claimed_idx - claim_transfer_fail_holder_balance_unchanged - claim_transfer_fail_contract_balance_unchanged - claim_transfer_fail_then_retry_succeeds - claim_transfer_fail_multi_period_no_partial_state - claim_transfer_fail_does_not_affect_other_holder_state - claim_transfer_fail_does_not_affect_sibling_offering Security invariant verified: LastClaimedIdx is written AFTER try_transfer succeeds. A failed transfer leaves zero observable state change — no index advance, no balance movement, no partial period claims.
|
@Abdulmajeed82 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378