Conversation
11 tasks
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthrough
Changes채용 우대사항 저장 API 구현
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
PUT /cover-letters/{coverLetterId}/preferencesAPI를 추가했습니다.preferences를 trim 후 Unicode code point 기준 1~3000자로 검증하고, 실패 시 공통 에러 응답의 field details를 반환하도록 구현했습니다.CoverLetter에 채용 우대사항 저장 도메인 메서드를 추가하고, 저장 시updatedAt을 함께 갱신했습니다.스크린샷
1. test 전 상황 확인
2. preference 등록 api 요청 진행 @PutMapping("/cover-letters/{coverLetterId}/preferences")
3. api 실행 후 db 확인 (preference 저장 확인)
4. preference를 공백으로 요청하였을 시 에러 응답 확인
관련 이슈
문서 반영
docs/api/README.mddocs/api/cover-letters.mddocs/status.md확인 결과
git diff --check./gradlew test./gradlew checkSummary by CodeRabbit
새로운 기능
문서
테스트