Conversation
11 tasks
📝 WalkthroughWalkthrough
ChangesOpenAI 최초 첨삭 Client 구현
Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/daon/rewrite/reviewversion/client/OpenAiFirstReviewClient.java`:
- Around line 42-60: The request serialization in OpenAiFirstReviewClient is
being caught by the same try/catch as model invocation, so failures from
buildUserPrompt(request) and JSON_MAPPER.writeValueAsString(request) are
misclassified as OUTPUT_VALIDATION_FAILED. Move the
prompt-building/serialization step outside the
chatClient.prompt().system(...).user(...).call() try block, or catch
serialization separately in buildUserPrompt, so only response parsing from
entity(OpenAiFirstReviewResponse.class) maps to output validation while request
serialization is handled as a distinct provider/request error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 1f77ec49-7eda-4dcf-b674-5b3ab8a69286
📒 Files selected for processing (11)
docs/status.mdsrc/main/java/com/daon/rewrite/reviewversion/client/FirstReviewClient.javasrc/main/java/com/daon/rewrite/reviewversion/client/FirstReviewClientException.javasrc/main/java/com/daon/rewrite/reviewversion/client/FirstReviewQuestion.javasrc/main/java/com/daon/rewrite/reviewversion/client/FirstReviewRequest.javasrc/main/java/com/daon/rewrite/reviewversion/client/FirstReviewResult.javasrc/main/java/com/daon/rewrite/reviewversion/client/OpenAiFirstReviewClient.javasrc/main/java/com/daon/rewrite/reviewversion/client/OpenAiFirstReviewResponse.javasrc/main/resources/application.yamlsrc/test/java/com/daon/rewrite/reviewversion/client/OpenAiFirstReviewClientTest.javasrc/test/resources/application-test.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
FirstReviewClient와 Spring AI 기반 구현체를 추가합니다.관련 이슈
문서 반영
docs/status.md확인 결과
./gradlew test./gradlew checkgit diff --checkChatModel로 검증Summary by CodeRabbit
새 기능
버그 수정