Conversation
22 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🧪 테스트 결과
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough기존 공유 UI 컴포넌트(Badge, Button, Logo, Title, Spinner, PageHeader, QueryProvider 등) 전반의 export 방식을 ChangesNamed Export 리팩토링
Input 컴파운드 컴포넌트 및 FormField 어댑터 추가
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🚦 CI 검증 결과
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/shared/ui/input/Input.stories.tsx`:
- Around line 250-257: The Button component in the WithButton story does not
have an explicit type attribute specified, which could cause unintended form
submission when the component is reused within a form context since buttons
default to type="submit". Add the type attribute with the value "button" to the
Button component in the WithButton story render function to ensure it does not
trigger form submission and serves as a safe example in documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8b795081-8f70-4723-9fb8-a46c427450df
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (42)
.vscode/project.code-snippetsdocs/CONVENTIONS.mdpackage.jsonsrc/shared/providers/QueryProviders.tsxsrc/shared/styles/base/colors.csssrc/shared/ui/badge-title/BadgeTitle.stories.tsxsrc/shared/ui/badge-title/BadgeTitle.tsxsrc/shared/ui/badge-title/index.tssrc/shared/ui/badge/Badge.stories.tsxsrc/shared/ui/badge/Badge.tsxsrc/shared/ui/badge/BadgeGroup.stories.tsxsrc/shared/ui/badge/BadgeGroup.tsxsrc/shared/ui/badge/index.tssrc/shared/ui/button/Button.tsxsrc/shared/ui/button/ButtonContent.tsxsrc/shared/ui/button/LinkButton.tsxsrc/shared/ui/button/index.tssrc/shared/ui/form-field/FormField.tsxsrc/shared/ui/form-field/FormField.types.tssrc/shared/ui/form-field/index.tssrc/shared/ui/input/Input.stories.tsxsrc/shared/ui/input/Input.tsxsrc/shared/ui/input/Input.types.tssrc/shared/ui/input/InputContext.tssrc/shared/ui/input/InputControl.tsxsrc/shared/ui/input/InputErrorMessage.tsxsrc/shared/ui/input/InputField.tsxsrc/shared/ui/input/InputLabel.tsxsrc/shared/ui/input/index.tssrc/shared/ui/logo/SymbolLogo.stories.tsxsrc/shared/ui/logo/SymbolLogo.tsxsrc/shared/ui/logo/TextLogo.stories.tsxsrc/shared/ui/logo/TextLogo.tsxsrc/shared/ui/logo/index.tssrc/shared/ui/page-header/PageHeader.stories.tsxsrc/shared/ui/page-header/PageHeader.tsxsrc/shared/ui/page-header/index.tssrc/shared/ui/spinner/Spinner.tsxsrc/shared/ui/spinner/index.tssrc/shared/ui/title/Title.stories.tsxsrc/shared/ui/title/Title.tsxsrc/shared/ui/title/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
체크 사항
📝작업 내용
Input 공통 컴포넌트 구현
Input.Label,Input.Field,Input.Control,Input.ErrorMessage를 조합할 수 있습니다.text,number,url타입을 지원합니다.required,disabled,invalid상태를 Root에서 관리합니다.htmlFor,id를 자동으로 연결했습니다.Input.Control을 구현했습니다.className확장을 지원합니다.React Hook Form 연동
Controller를 공통 UI와 연결하는FormField를 구현했습니다.field,fieldState,formState와 함께invalid,errorMessage를 제공합니다.readonly 미지원
dl,dt,dd를 사용하는 것이 의미상 적절하다고 판단했습니다.readonlyInput은 여전히 키보드 포커스를 받고 입력값 선택과 복사가 가능한 실제 form control이므로 단순 정보 표시 목적과 차이가 있습니다.dt를 Label과 같은 스타일로,dd를 Input과 같은 스타일로 구현할 수 있습니다.readonly를 지원하지 않으며, 실질적인 입력 차단이 필요한 경우에는disabled를 사용합니다.named export 적용
index.ts에서도 원본 컴포넌트의 이름을 그대로 명시적으로 재export하도록 변경했습니다.page.tsx,layout.tsx는 예외로 유지했습니다.스타일 및 디자인 토큰
#FF5656토큰을 추가했습니다.Storybook 및 문서화
스크린샷 (선택)
추가한 라이브러리 (선택)
react-hook-form💬리뷰 요구사항(선택)
readonlyInput 대신dl,dt,dd를 사용하도록 구분한 기준을 확인 필요Summary by CodeRabbit
Release Notes