[♻️ Refactor/#45] 폼 필드 불필요 코드 정리#46
Merged
Merged
Conversation
Input과 TextArea의 ARIA 속성 및 타입 정의를 실제 동작에 맞게 정리했습니다. 중복 required ARIA와 불필요한 중간 변수를 제거하고 주석을 최신 구현 기준으로 맞췄습니다.
6 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
WalkthroughInput, TextArea, FormControl 공통 폼 컴포넌트에서 중복된 ChangesInput/TextArea 공통 폼 컴포넌트 접근성 속성 및 타입 정리
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🧪 테스트 결과
|
🚦 CI 검증 결과
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
체크 사항
📝작업 내용
Input/TextArea ARIA 속성 정리
required속성과 중복되는aria-required를 제거했습니다.Input.ErrorMessage주석에서 현재 구현과 맞지 않는aria-describedby설명을 제거했습니다.aria-errormessage와 연결되도록 설명을 정리했습니다.TextArea Field 코드 정리
TextArea.Field에서 한 번만 사용되는describedBy중간 변수를 제거했습니다.aria-describedby가 연결되도록 기존 동작은 유지했습니다.Props 타입 정리
Input.Field에서readOnlyprop을 사용할 수 있도록 타입 제한을 정리했습니다.TextArea.Label,TextArea.ErrorMessageprops 타입을 프로젝트 컨벤션에 맞게interface로 변경했습니다.스크린샷 (선택)
UI 변경 없음
추가한 라이브러리 (선택)
없음
💬리뷰 요구사항(선택)
없음
Summary by CodeRabbit
Release Notes
Bug Fixes
readOnly속성을 전달할 수 있도록 개선Documentation
Refactor