Repository navigation
Conversation
…he quiz is submitted Xerte marks a progress-bar milestone complete as soon as its page has been viewed, so the circle for each quiz lit up on opening the quiz, which contradicted the contents-page tick that now means "submitted". XENITH.PROGRESSBAR.update is wrapped so that after every engine update a quiz milestone is lit only when that quiz has reported its score (the same persisted flag the tick uses), and its label reads "Milestone: <quiz>: Complete" or "Milestone: <quiz> (Quiz not yet submitted)". Marker i is the i-th non-menu, non-standalone page with milestone="true", the order the engine builds them in. Also refreshed from the same hooks as the tick (page load, menu tick, page exit, quiz score), so it updates on submission and after a resume. Welcome page wording and docs updated; the header progress bar test now checks that opening a quiz does not light its marker, submitting it does, and the resumed session in the tick test checks the marker is restored. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MfWFRfRw3sR98Vq48EKEYa
📖 Course content previewDownload the
|
Resolves the conflict on the learningObject root line, where both sides recompiled the script attribute: kept this branch's root attributes (they are identical apart from the script) and regenerated the attribute from the merged source/scorm_progress.js with tools/sync_root_script.py. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MfWFRfRw3sR98Vq48EKEYa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #10. The circles on the header progress bar are Xerte milestone markers, and the engine marks a milestone complete as soon as its page has been viewed. So each quiz circle lit up on opening the quiz, which contradicted the contents-page tick that now means "submitted".
Change
XENITH.PROGRESSBAR.updateis wrapped so that after every engine update a quiz milestone is lit only when that quiz has reported its score (the same persisted flag the tick uses). Its label readsMilestone: <quiz>: CompleteorMilestone: <quiz> (Quiz not yet submitted). Marker i is the i-th non-menu, non-standalone page withmilestone="true", the order the engine builds them in. The correction also runs from the same hooks as the tick (page load, menu tick, page exit, quiz score), so it updates on submission and after a resume.The bar itself and its percentage are unchanged: they still count pages viewed and are labelled that way. Only the quiz circles change meaning.
Welcome page wording ("the circles on it light up as you submit each quiz") and docs updated.
Tests
test_header_progress_bar_counts_viewed_pagesnow checks that opening Theme 1 Quiz does not light its marker, submitting it lights only that marker, and the titles read as above. The resumed session intest_quiz_tick_means_submitted_not_openedchecks the marker is restored from the persisted flag. 22/22 pass locally against the v0.0.7 release package with the newdata.xml; CI builds through a real XOT container.After submitting Theme 1 Quiz and only opening Theme 2 Quiz: the first circle is lit, the second stays hollow even though its bar segment shows the page was viewed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MfWFRfRw3sR98Vq48EKEYa
Generated by Claude Code