Skip to content

RIG-401 feat: implementation#236

Merged
ArLeyar merged 3 commits intomainfrom
feat/RIG-401-pipeline-engineer-stage
Apr 7, 2026
Merged

RIG-401 feat: implementation#236
ArLeyar merged 3 commits intomainfrom
feat/RIG-401-pipeline-engineer-stage

Conversation

@ArLeyar
Copy link
Copy Markdown
Contributor

@ArLeyar ArLeyar commented Apr 7, 2026

Summary

Pipeline engineer task 20260407-039.

Linear: RIG-401

…nostic

Thread agent_runtime into prompt vars and add computed template variables:
- {skill_section}: runtime × language → Claude skill invocation / Codex guidance / CLAUDE.md fallback
- {verification_section}: test_commands from pipeline YAML or generic CLAUDE.md fallback
- {reviewer_skill_section}: now runtime-aware (Claude → /code-review, others → inline checklist)
- {commit_format_hint}: references repo CLAUDE.md instead of hardcoded format

Update engineer.md to use template vars instead of hardcoded /rust + cargo commands.
Add language + test_commands to all 3 pipeline YAMLs (default, honeyjourney, economy).
Inject agent_runtime in poll.rs and task_builder.rs prompt builders.

13 new tests covering all runtime × language combinations + integration tests.
@ArLeyar ArLeyar added the ai-generated Created by AI agent label Apr 7, 2026
@ArLeyar
Copy link
Copy Markdown
Contributor Author

ArLeyar commented Apr 7, 2026

Code review

Found 1 issue:

  1. Stages without explicit runtime default to claude-code, so honeyjourney.yaml's analyst/deployer stages will generate skill: "python" — but no /python skill exists in Claude Code. The skill lookup will fail or stall on every analyst/deployer task in the honeyjourney pipeline.

} else {
"## FIRST: Invoke the Code Review skill\n\
Before starting the review, invoke the `/code-review` skill using the Skill tool \
(skill: \"code-review:code-review\"). This loads the full review checklist and \
standards you MUST follow.\n\n\
## Review Protocol\n\
1. Invoke `/code-review` skill (Skill tool, skill: \"code-review:code-review\")"
.to_string()

Root config that triggers it:

templates:
verdict_instruction: "Output your verdict on the LAST line of your response"
nit_threshold: "0"
language: python

Fix: add a runtime guard in compute_derived_vars so skill invocation is only generated for languages with a known installed skill (e.g. ["rust"] allowlist), or set an explicit non-claude runtime on the honeyjourney analyst/deployer stages.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@ArLeyar ArLeyar enabled auto-merge (squash) April 7, 2026 11:05
@ArLeyar ArLeyar merged commit 06f554d into main Apr 7, 2026
4 checks passed
@ArLeyar ArLeyar deleted the feat/RIG-401-pipeline-engineer-stage branch April 7, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Created by AI agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant