Skip to content

RIG-402 feat: implementation#237

Merged
ArLeyar merged 2 commits intomainfrom
feat/RIG-402-pipeline-engineer-stage
Apr 7, 2026
Merged

RIG-402 feat: implementation#237
ArLeyar merged 2 commits intomainfrom
feat/RIG-402-pipeline-engineer-stage

Conversation

@ArLeyar
Copy link
Copy Markdown
Contributor

@ArLeyar ArLeyar commented Apr 7, 2026

Summary

Pipeline engineer task 20260407-040.

Linear: RIG-402

@ArLeyar ArLeyar added the ai-generated Created by AI agent label Apr 7, 2026
@ArLeyar
Copy link
Copy Markdown
Contributor Author

ArLeyar commented Apr 7, 2026

Code review

No blockers. 1 nit.

  1. prev_lines tracking is now dead after switching to \x1b[J — it's still computed and reset on resize but passed to refresh_screen as _prev_lines (ignored). The two assignments can be removed.

ui::refresh_screen(&content, prev_lines, current_term_width);
prev_lines = content.lines().count();

The core approach is correct: \x1b[3J on initial clear and on resize prevents scrollback reflow (the root cause of the double-header), and replacing per-line prev_lines counting with \x1b[J (erase to bottom) handles variable-length renders more robustly regardless of whether the terminal resized between ticks.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@ArLeyar ArLeyar enabled auto-merge (squash) April 7, 2026 11:05
@ArLeyar ArLeyar merged commit 01a57ee into main Apr 7, 2026
2 checks passed
@ArLeyar ArLeyar deleted the feat/RIG-402-pipeline-engineer-stage branch April 7, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Created by AI agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant