Merged
Conversation
- display_model_name(): ClaudeCode=shorthand, Qwen=qwen, Gemini=strip gemini- prefix, Codex=explicit ID or nothing - Qwen completed tasks show duration instead of turns (qwen doesn't report turns) - Compact view now shows model for running tasks too - Updated tests: RIG-387 runtime-prefix tests replaced with RIG-399 per-runtime model tests
Contributor
Author
Code reviewFound 2 issues:
Lines 155 to 165 in c51142b
Lines 140 to 152 in c51142b 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Fix two review issues:
- Qwen: remove duration from Turns field — it duplicated the time
column, producing output like "3m (qwen/3m)"
- Gemini: replace rsplit_once('-') with version-aware parsing that
skips numeric segments, so "gemini-2.5-flash-preview-04-17" yields
"flash" instead of "17"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pipeline engineer task
20260407-041.Linear: RIG-399