Merged
Conversation
Effects processor previously used a single LinearClient for all effects. GitHub issues (e.g. honeyjourney#20) would hit the Linear API and get "Entity not found" errors. - Extract resolve_tracker_client() from pipeline_cmd.rs to shared tracker.rs - Route each effect in process_effects() to the correct tracker: GitHub identifiers (containing '#') resolve via tracker config, Linear identifiers use the passed-in client - Daemon now always processes effects (not gated on LINEAR_API_KEY), so GitHub-only setups work without Linear configured
Contributor
Author
Code reviewFound 2 issues:
werma/engine/src/daemon/mod.rs Lines 159 to 170 in 23e2e3f
werma/engine/src/pipeline/effects.rs Lines 82 to 91 in 23e2e3f 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
1. Load UserConfig once at daemon startup instead of every 5s tick, consistent with how linear_poll, cmd_runner, notifier are initialized. 2. When LINEAR_API_KEY is absent, skip Linear effects (leave pending) instead of dead-lettering them. Preserves pre-RIG-404 behavior where effects waited for the client to become available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pipeline engineer task
20260409-001.Linear: RIG-404