Repository navigation
fix: report source line number for mismatched grid row width - #8
Merged
Merged
Conversation
RizgarOzan
approved these changes
Oct 5, 2026
RizgarOzan
left a comment
RizgarOzan
left a comment
Owner
There was a problem hiding this comment.
Thanks @Shadow16Ua, this looks good. I ran the core tests locally on your branch (52/52 pass) and checked that your new test fails against the old LevelText.cs, so it really pins the line number. All three points in #7's "Done when" list are covered. It'll be merged shortly.
Owner
|
Merged, thank you @Shadow16Ua! Clean fix, and the test fails without it. If you want another one, #1-#6 are open (new levels and a bot strategy). |
RizgarOzan
added a commit
that referenced
this pull request
Oct 10, 2026
jay23606's Rainfall level (#9) is the first sample that uses `-` cells, so I re-ran the curve with it and put the new rows in the README table and in docs/curve-1000.csv. The six old levels came out the same, only the throughput column moved. 14,000 games now take about 4.3 seconds here. I also added `-` to the level format legend, since nothing in the README mentioned it, and bumped the core test count to 60 after #8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7
Changes:
LevelText.cs.