Skip to content

Configurable API version #1

Description

@inputsh

So, I see that the BASE_URL is hardcoded to http://{0}:1925/5/{1}.

My specific TV (43PUS6262) doesn't seem to respond to /5/, but /6/:

$ wget http://<IP>:1925/5/audio/volume
--2019-10-14 16:04:24--  http://<IP>:1925/5/audio/volume
Connecting to <IP>:1925... connected.
HTTP request sent, awaiting response... 403 Forbidden
2019-10-14 16:04:24 ERROR 403: Forbidden.

$ wget http://<IP>:1925/6/audio/volume
--2019-10-14 16:04:27--  http://<IP>:1925/6/audio/volume
Connecting to <IP>:1925... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/json]
Saving to: ‘volume’

volume                                [ <=>            ]      58  --.-KB/s    in 0s      

2019-10-14 16:04:27 (730 KB/s) - ‘volume’ saved [58]

This makes me think that the API version should really be configurable from configuration.yaml, with /5/ possibly being a default value?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions