Repository navigation
fix(sandbox): libuv修正入りのNodeが出たら node --test の事前拒否を自動で外す (#734) - #744
Merged
Merged
Conversation
…t the node --test pre-check (#734) The pre-approval rejection of process-isolated `node --test` in the Windows sandbox ignored the Node version, so it would keep rejecting even after a Node release bundling libuv >= 1.53 (libuv/libuv#5181) ships. Releases newer than the last one known to bundle an older libuv are now left to the in-sandbox pipe guard, which reads the real libuv version and still fails fast without the fix. Every currently published release keeps the existing rejection. Refs #734 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🗺️ PR Walkthrough Note Windows サンドボックスでの Node.js Changed files (2)
Reviewed by vibe-editor-reviewer — head |
12 tasks
There was a problem hiding this comment.
✅ Code review
Tip
LGTM — actionable issues were not found.
確認内容
- ✅ 変更箇所と関連するコード経路を確認
- ✅ リードが指定した重点ファイルの精査(Claude)を確認
レビュー所感
Node の PE バージョン資源を使う新しい早期拒否判定と、サンドボックス起動時に libuv の実バージョンを確認するガードとの連携を中心に確認しました。通過する版でもガードが環境に設定されることを確認し、重大な再現可能な欠陥は見つかりませんでした。
🛡️ blockingな指摘はありません。bot側の安全設定により、merge-relevantなAPPROVEではなくCOMMENTとして投稿します。
Review coverage & tooling
- Files: 2 reviewed (+62 / -3)
- Full file bodies included: 0 / 2
- Reviewer roles: numeric_consistency (deterministic), codex_primary (gpt-6-luna), claude_specialist (claude-sonnet-5-5, fixed-diff only, partial)
Reviewed by vibe-editor-reviewer — head d2a0698
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Windows サンドボックスでの
node --test(プロセス分離あり)の事前拒否は、Node のバージョンを見ずに常に拒否していました。そのため、libuv 1.53 以上(libuv/libuv#5181 の修正入り)を含む Node が公開されても、拒否し続ける状態でした。この PR で、各系列の「libuv 1.53 未満が入っている最新の公開版」より新しい Node は事前拒否せず、サンドボックス内のパイプガード(#686)に判断を任せるようにしました。ガードは実際の
process.versions.uvを見て、修正が無ければ従来どおり即座に失敗させます。そのため、この表を更新しなくても安全側に倒れます。背景(#734 の判断)
検証
command-runner.test.ts、default-tools.test.ts、sandbox-node-pipe-guard.test.ts: 78件 PASSsandbox-node-pipe-guard.integration.test.ts: 手元では変更前と同じく失敗します。手元の Node 24.13.0 で子プロセスが ENOENT になる、既知の環境差です(tasks/issue-549-node-pipe-fastfail.mdに記載)。CI での確認に委ねますRefs #734
🤖 Generated with Claude Code