feat(tui): support Windows and WSL UNC paths in file drag-and-drop - #1
Closed
477174 wants to merge 2 commits into
Closed
feat(tui): support Windows and WSL UNC paths in file drag-and-drop#1477174 wants to merge 2 commits into
477174 wants to merge 2 commits into
Conversation
When running opencode in WSL, dragging files from Windows Explorer pastes Windows-style paths (C:\Users\...) or WSL UNC paths (\\wsl$\distro\...) which were not recognized by the paste handler. - Add isWindowsPath/isFilePath/resolveDroppedPath helpers for platform-aware path detection and conversion - Update all path detection guards in onPaste to accept Windows paths - Convert drive-letter paths to /mnt/<drive>/... on WSL - Convert \\wsl$/\\wsl.localhost UNC paths to native WSL paths - Strip double quotes from dropped paths (Windows terminal behavior) - Pass-through on native Windows and other platforms (no behavior change) Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
PowerShell processes spawned from WSL cannot access the Windows clipboard session (fundamental session isolation). The previous code tried PowerShell on WSL, which always failed silently. - Skip PowerShell clipboard read on WSL (dead code, ~500ms wasted) - Fix wl-paste/wl-copy on WSLg: override XDG_RUNTIME_DIR to /mnt/wslg/runtime-dir where the Wayland socket actually lives - Requires wl-clipboard package (apt install wl-clipboard) Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two WSL clipboard/file issues fixed:
C:\Users\...,\\wsl$\distro\...) which were treated as plain text instead of file attachmentsXDG_RUNTIME_DIRChanges
Commit 1:
feat(tui): support Windows and WSL UNC paths in file drag-and-dropFile:
packages/opencode/src/cli/cmd/tui/component/prompt/index.tsxisWindowsPath(),isFilePath(),resolveDroppedPath()helpersC:\Users\foo) →/mnt/c/Users/fooon WSL\\wsl$\Ubuntu\home\foo) →/home/fooon WSLCommit 2:
fix(tui): fix clipboard image paste on WSL via WSLg Wayland bridgeFile:
packages/opencode/src/cli/cmd/tui/util/clipboard.tswl-paste/wl-copyon WSLg: overrideXDG_RUNTIME_DIRto/mnt/wslg/runtime-dirwhere the Wayland socket actually liveswl-clipboardpackage (apt install wl-clipboard)Platform behavior
C:\...)\\wsl$\...)Prerequisites for WSL image paste
WSLg must be enabled (default on Windows 11 with recent WSL2).