Skip to content

Make minor C++ docstring adjustments - #13492

Merged
hongkai-dai merged 1 commit into
RobotLocomotion:masterfrom
EricCousineau-TRI:feature-2020-06-03-minor-doc
Jun 3, 2020
Merged

Make minor C++ docstring adjustments#13492
hongkai-dai merged 1 commit into
RobotLocomotion:masterfrom
EricCousineau-TRI:feature-2020-06-03-minor-doc

Conversation

@EricCousineau-TRI

@EricCousineau-TRI EricCousineau-TRI commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

As part of #13461 (but also good as a standalone)


This change is Reviewable

@EricCousineau-TRI EricCousineau-TRI added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Jun 3, 2020

@EricCousineau-TRI EricCousineau-TRI left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri for both reviews, please.
+(status: single reviewer ok)

Reviewable status: LGTM missing from assignee jwnimmer-tri(platform) (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: both.

Reviewed 7 of 7 files at r1.
Reviewable status: 1 unresolved discussion (waiting on @EricCousineau-TRI)


solvers/test/semidefinite_program_examples.h, line 90 at r1 (raw file):

 * s.t [x0 x1] is psd
 *     [x1 x0]
 *

Both of these changed lines seem worse to me. We now have a weird blank line inbetween the exposition of the mathematical program, inconsistent within this definition itself, and different than its peers higher up in the file, etc.

@EricCousineau-TRI
EricCousineau-TRI force-pushed the feature-2020-06-03-minor-doc branch from 718c91e to dcac052 Compare June 3, 2020 20:26
@EricCousineau-TRI
EricCousineau-TRI force-pushed the feature-2020-06-03-minor-doc branch from dcac052 to 5a2e391 Compare June 3, 2020 20:26

@EricCousineau-TRI EricCousineau-TRI left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)


solvers/test/semidefinite_program_examples.h, line 90 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Both of these changed lines seem worse to me. We now have a weird blank line inbetween the exposition of the mathematical program, inconsistent within this definition itself, and different than its peers higher up in the file, etc.

Done.

@jwnimmer-tri jwnimmer-tri removed the status: single reviewer ok https://drake.mit.edu/reviewable.html label Jun 3, 2020

@jwnimmer-tri jwnimmer-tri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-(status: single reviewer ok)

+@hongkai-dai for feature review of semidefinite_program_examples.h (only), please.

Reviewed 1 of 1 files at r2.
Reviewable status: LGTM missing from assignee hongkai-dai (waiting on @hongkai-dai)

@hongkai-dai hongkai-dai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),hongkai-dai

@hongkai-dai
hongkai-dai merged commit fff0dcd into RobotLocomotion:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants