Make minor C++ docstring adjustments - #13492
Conversation
EricCousineau-TRI
left a comment
There was a problem hiding this comment.
+@jwnimmer-tri for both reviews, please.
+(status: single reviewer ok)
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform) (waiting on @jwnimmer-tri)
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: 1 unresolved discussion (waiting on @EricCousineau-TRI)
solvers/test/semidefinite_program_examples.h, line 90 at r1 (raw file):
* s.t [x0 x1] is psd * [x1 x0] *
Both of these changed lines seem worse to me. We now have a weird blank line inbetween the exposition of the mathematical program, inconsistent within this definition itself, and different than its peers higher up in the file, etc.
718c91e to
dcac052
Compare
dcac052 to
5a2e391
Compare
EricCousineau-TRI
left a comment
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
solvers/test/semidefinite_program_examples.h, line 90 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Both of these changed lines seem worse to me. We now have a weird blank line inbetween the exposition of the mathematical program, inconsistent within this definition itself, and different than its peers higher up in the file, etc.
Done.
jwnimmer-tri
left a comment
There was a problem hiding this comment.
-(status: single reviewer ok)
+@hongkai-dai for feature review of semidefinite_program_examples.h (only), please.
Reviewed 1 of 1 files at r2.
Reviewable status: LGTM missing from assignee hongkai-dai (waiting on @hongkai-dai)
hongkai-dai
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),hongkai-dai
As part of #13461 (but also good as a standalone)
This change is