[wheel] Remove pythonX.Y symlink indirection on macOS - #24919
Conversation
The `python` spelling is needed for `install-wheel.sh` and `test-wheel.sh` to be reusable across the Linux and macOS builders, but it being a symlink pointing to `pythonX.Y` (the directory where the venv lives) is unnecessary. `provision-build.sh` already creates a unique test root each time a wheel is tested (via `macos/provision-test-python.sh`). The broader motivation for the change is to remove confusion around the uniqueness of the test root and Python virtual environment ahead of a future commit to support testing a single wheel with multiple Python versions. Co-authored-by: Matthew Woehlke <matthew.woehlke@kitware.com>
tyler-yankee
added
the
release notes: none
github-project-automation
Bot
moved this to On deck
in build system, continuous integration, distribution
|
@drake-jenkins-bot mac-arm-tahoe-clang-wheel-experimental-release please. |
tyler-yankee
moved this from On deck
to In review
in build system, continuous integration, distribution
mwoehlke-kitware
left a comment
mwoehlke-kitware
left a comment
There was a problem hiding this comment.
@mwoehlke-kitware reviewed 2 files and made 2 comments.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on tyler-yankee).
Suggestion:
venv lives) is unnecessary. `provision-build.sh` already creates (via
`macos/provision-test-python.sh`) a unique test root each time a wheel
is tested.
tyler-yankee
left a comment
tyler-yankee
left a comment
There was a problem hiding this comment.
+a:@SeanCurtis-TRI for platform review per schedule (tomorrow), please.
@tyler-yankee reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee SeanCurtis-TRI(platform) (waiting on SeanCurtis-TRI and tyler-yankee).
-- commits line 9 at r1:
Happy to take this suggestion upon merge.
SeanCurtis-TRI
left a comment
SeanCurtis-TRI
left a comment
There was a problem hiding this comment.
@SeanCurtis-TRI reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: 1 unresolved discussion (waiting on tyler-yankee).
tyler-yankee
left a comment
tyler-yankee
left a comment
There was a problem hiding this comment.
@tyler-yankee resolved 1 discussion.
Reviewable status:complete! all discussions resolved, LGTM from assignees SeanCurtis-TRI(platform),mwoehlke-kitware (waiting on tyler-yankee).
github-project-automation
Bot
moved this from In review
to Done
in build system, continuous integration, distribution
3 participants
The
pythonspelling is needed forinstall-wheel.shandtest-wheel.shto be reusable across the Linux and macOS builders, but it being a symlink pointing topythonX.Y(the directory where the venv lives) is unnecessary.provision-build.shalready creates a unique test root each time a wheel is tested (viamacos/provision-test-python.sh).The broader motivation for the change is to remove confusion around the uniqueness of the test root and Python virtual environment ahead of a future commit to support testing a single wheel with multiple Python versions.
Towards #24903.
This change is