[workspace] Automate bazelisk_internal upgrades - #24927
Open
tyler-yankee wants to merge 1 commit into
Open
Conversation
Create an `upgrade.py` script which supplements the GitHub upgrade performed by `new_release.py`. That is, unlike e.g. crate_universe for which the upgrade script is the entire upgrade, here we wish to still perform the automated upgrade (fetch from GitHub), and then just use the script to sync some additional files. This commit is only infrastructure (including a formatting-only change to `packages.json`); no actual upgrade is performed.
tyler-yankee
commented
Aug 28, 2026
tyler-yankee
left a comment
Contributor
Author
There was a problem hiding this comment.
@tyler-yankee reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers.
tools/workspace/bazelisk_internal/upgrade.py line 49 at r1 (raw file):
"bazel", ["bazel", "run", "//tools/workspace/bazelisk_internal:upgrade"], )
FYI This follows the pattern for drake/tools/workspace/crate_universe/upgrade.py established in #24810.
Code quote:
bazelisk_license_path = os.environ.get("DRAKE_BAZELISK_LICENSE_PATH")
if bazelisk_license_path is None:
# Operate relative to the root of the Drake source tree.
os.chdir(Path(__file__).resolve().parents[3])
os.execvp(
"bazel",
["bazel", "run", "//tools/workspace/bazelisk_internal:upgrade"],
)
tyler-yankee
commented
Aug 31, 2026
tyler-yankee
left a comment
Contributor
Author
There was a problem hiding this comment.
+a:@tom-osika for feature review, please.
@tyler-yankee made 1 comment.
Reviewable status: LGTM missing from assignee tom-osika, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on tom-osika).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create an
upgrade.pyscript which supplements the GitHub upgrade performed bynew_release.py. That is, unlike e.g. crate_universe for which the upgrade script is the entire upgrade, here we wish to still perform the automated upgrade (fetch from GitHub), and then just use the script to sync some additional files.This commit is only infrastructure (including a formatting-only change to
packages.json); no actual upgrade is performed.Towards #24850.
This change is