Skip to content

[workspace] Automate bazelisk_internal upgrades - #24927

Open
tyler-yankee wants to merge 1 commit into
RobotLocomotion:masterfrom
tyler-yankee:bazelisk-upgrades
Open

[workspace] Automate bazelisk_internal upgrades#24927
tyler-yankee wants to merge 1 commit into
RobotLocomotion:masterfrom
tyler-yankee:bazelisk-upgrades

Conversation

@tyler-yankee

@tyler-yankee tyler-yankee commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Create an upgrade.py script which supplements the GitHub upgrade performed by new_release.py. That is, unlike e.g. crate_universe for which the upgrade script is the entire upgrade, here we wish to still perform the automated upgrade (fetch from GitHub), and then just use the script to sync some additional files.

This commit is only infrastructure (including a formatting-only change to packages.json); no actual upgrade is performed.

Towards #24850.


This change is Reviewable

Create an `upgrade.py` script which supplements the GitHub upgrade
performed by `new_release.py`. That is, unlike e.g. crate_universe
for which the upgrade script is the entire upgrade, here we wish to
still perform the automated upgrade (fetch from GitHub), and then just
use the script to sync some additional files.

This commit is only infrastructure (including a formatting-only change
to `packages.json`); no actual upgrade is performed.
@tyler-yankee tyler-yankee added priority: low release notes: none This pull request should not be mentioned in the release notes labels Aug 28, 2026

@tyler-yankee tyler-yankee left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyler-yankee reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers.


tools/workspace/bazelisk_internal/upgrade.py line 49 at r1 (raw file):

            "bazel",
            ["bazel", "run", "//tools/workspace/bazelisk_internal:upgrade"],
        )

FYI This follows the pattern for drake/tools/workspace/crate_universe/upgrade.py established in #24810.

Code quote:

    bazelisk_license_path = os.environ.get("DRAKE_BAZELISK_LICENSE_PATH")
    if bazelisk_license_path is None:
        # Operate relative to the root of the Drake source tree.
        os.chdir(Path(__file__).resolve().parents[3])
        os.execvp(
            "bazel",
            ["bazel", "run", "//tools/workspace/bazelisk_internal:upgrade"],
        )

@tyler-yankee tyler-yankee left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+a:@tom-osika for feature review, please.

@tyler-yankee made 1 comment.
Reviewable status: LGTM missing from assignee tom-osika, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on tom-osika).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low release notes: none This pull request should not be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants