[solvers] Name quadratic cost when PSD decomposition fails - #24932
Open
castor639 wants to merge 1 commit into
Open
[solvers] Name quadratic cost when PSD decomposition fails#24932castor639 wants to merge 1 commit into
castor639 wants to merge 1 commit into
Conversation
Add math::MaybeDecomposePSDmatrixIntoXtransposeTimesX that returns error details instead of throwing, and use it from conic solvers so failures identify the offending QuadraticCost. Fixes RobotLocomotion#20892.
ggould-tri
reviewed
Sep 1, 2026
ggould-tri
left a comment
Contributor
There was a problem hiding this comment.
+(component: mathematical program) Assigning +a:@hongkai-dai as area lead for mathematical programs; feel free to re-delegate.
@ggould-tri made 1 comment.
Reviewable status: LGTM missing from assignee hongkai-dai, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on hongkai-dai).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add math::MaybeDecomposePSDmatrixIntoXtransposeTimesX that returns error details instead of throwing, and use it from conic solvers so failures identify the offending QuadraticCost.
Fixes #20892.
This change is