[parsing] Use DiagnosticPolicy for model directives errors - #24938
Open
castor639 wants to merge 1 commit into
Open
[parsing] Use DiagnosticPolicy for model directives errors#24938castor639 wants to merge 1 commit into
castor639 wants to merge 1 commit into
Conversation
Wire model directives loading and parsing to DiagnosticPolicy so errors follow the same non-fatal policy path as URDF and SDFormat. IsValid() schema checks report via the policy, and parser throws are replaced with diagnostic.Error() plus continue/return. Add tests that a non-fatal error policy does not crash the parser. Fixes RobotLocomotion#18052
ggould-tri
added
the
component: multibody parsing
ggould-tri
reviewed
Sep 1, 2026
ggould-tri
left a comment
ggould-tri
left a comment
Contributor
There was a problem hiding this comment.
+(component: multibody parsing) Assigning +a:@rpoyner-tri as parsers lead. Feel free to re-delegate.
@ggould-tri made 1 comment.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on rpoyner-tri).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire model directives loading and parsing to DiagnosticPolicy so errors follow the same non-fatal policy path as URDF and SDFormat. IsValid() schema checks report via the policy, and parser throws are replaced with diagnostic.Error() plus continue/return. Add tests that a non-fatal error policy does not crash the parser.
Fixes #18052
This change is