Skip to content

Client: Refactor Asset Server functionality#79

Open
dhars9-roche wants to merge 10 commits into
mainfrom
enh/update-asset-server
Open

Client: Refactor Asset Server functionality#79
dhars9-roche wants to merge 10 commits into
mainfrom
enh/update-asset-server

Conversation

@dhars9-roche

@dhars9-roche dhars9-roche commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
  • AssetServer now inherits from BaseServer — removed all duplicated get, put, post, parse, add_params, and url implementations.
  • headers property on BaseServer (returns None by default) — subclasses override it to inject auth headers instead of overriding the HTTP methods.
  • Fixed HTTP Warning header handling — old check_asset_warnings only triggered on status_code < 200 (wrong — those are informational codes). New _check_response_warnings checks on every response per RFC 7234, surfaces via UserLog().alert().
  • Fixed warning suppression — replaced blanket with warnings.catch_warnings(record=True) (silently swallowed all warnings) with a targeted urllib3.InsecureRequestWarning filter when ssl_verify=False.
  • parse() now raises IncorrectServerResponseError on bad JSON instead of a raw JSONDecodeError.

@dhars9-roche dhars9-roche self-assigned this Jun 17, 2026
@dhars9-roche dhars9-roche added Type: Refactor Pull requests that refactors the codebase Status: In Progress labels Jun 17, 2026
@dhars9-roche dhars9-roche marked this pull request as ready for review June 17, 2026 23:08
@dhars9-roche dhars9-roche changed the title Client: Refactor Asset Server Client: Refactor Asset Server functionality Jun 17, 2026
@dhars9-roche

Copy link
Copy Markdown
Contributor Author

All Unit tests are passing fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Review Needed Type: Refactor Pull requests that refactors the codebase

Development

Successfully merging this pull request may close these issues.

1 participant