Skip to content

fix(fuselage): Improve form input accessibility (A11y) #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harshit2405-2004 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(fuselage): Improve form input accessibility (A11y) #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5610c1d
fix(fuselage): add aria-label and roles to PasswordInput
Harshit2405-2004 Mar 6, 2026
e203bf1
Merge branch 'main' into fix/password-input-a11y
Harshit2405-2004 Mar 6, 2026
c4242ad
Merge branch 'main' into fix/password-input-a11y
Harshit2405-2004 Apr 18, 2026
11fe6ac
fix(password-input): use IconButton as addon toggle
Harshit2405-2004 Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/password-a11y.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@rocket.chat/fuselage': patch
'@rocket.chat/fuselage-forms': patch
---

Fix PasswordInput a11y violations by adding ARIA attributes to the toggle icon.
14 changes: 9 additions & 5 deletions packages/fuselage/src/components/PasswordInput/PasswordInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { useToggle } from '@rocket.chat/fuselage-hooks';
import { forwardRef } from 'react';

import { Icon } from '../Icon';
import { IconButton } from '../Button';
import { InputBox, type InputBoxProps } from '../InputBox';

// TODO: fix a11y issues


export type PasswordInputProps = Omit<InputBoxProps, 'type'>;

Expand All @@ -19,10 +19,14 @@ const PasswordInput = forwardRef<HTMLInputElement, PasswordInputProps>(
<InputBox
type={hidden ? 'password' : 'text'}
addon={
<Icon
name={hidden ? 'eye-off' : 'eye'}
size={20}
<IconButton
icon={hidden ? 'eye-off' : 'eye'}
mini
onClick={handleAddonClick}
role="button"
tabIndex={0}
aria-label={hidden ? "Show password" : "Hide password"}
onKeyDown={(e) => { if (e.key === 'Enter' || e.key === ' ') { e.preventDefault(); handleAddonClick(); } }}
/>
}
ref={ref}
Expand Down
Loading