Skip to content

fix(checkbox): remove unsupported is prop and clean up Storybook #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShubhamS2005 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −8
Open

fix(checkbox): remove unsupported is prop and clean up Storybook #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/fuselage/src/components/CheckBox/CheckBox.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ import CheckBox from './CheckBox';
export default {
title: 'Inputs/CheckBox',
component: CheckBox,
argTypes: {
is: { table: { disable: true } },
},
} satisfies Meta<typeof CheckBox>;

const Template: StoryFn<typeof CheckBox> = (args) => (
Expand Down
16 changes: 8 additions & 8 deletions packages/fuselage/src/components/CheckBox/CheckBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,35 +17,35 @@ const CheckBox = forwardRef<HTMLInputElement, CheckBoxProps>(function CheckBox(
const mergedRef = useMergedRefs(ref, innerRef);

useLayoutEffect(() => {
if (innerRef && innerRef.current && indeterminate !== undefined) {
if (innerRef.current && indeterminate !== undefined) {
innerRef.current.indeterminate = indeterminate;
}
}, [innerRef, indeterminate]);
}, [indeterminate]);

const handleChange = useCallback(
(event: FormEvent<HTMLInputElement>) => {
if (innerRef && innerRef.current && indeterminate !== undefined) {
if (innerRef.current && indeterminate !== undefined) {
innerRef.current.indeterminate = indeterminate;
}
onChange?.call(innerRef.current, event);
},
[innerRef, indeterminate, onChange],
[indeterminate, onChange],
);

return (
<Box is='label' className={className} rcx-check-box>
<Box is={'label' as unknown as React.ElementType} className={className} rcx-check-box>
{labelChildren}
<Box
is='input'
is={'input' as unknown as React.ElementType}
type='checkbox'
rcx-check-box__input
ref={mergedRef}
onChange={handleChange}
{...props}
/>
<Box is='i' rcx-check-box__fake aria-hidden='true' />
<Box is={'i' as unknown as React.ElementType} rcx-check-box__fake aria-hidden='true' />
</Box>
);
});

export default CheckBox;
export default CheckBox;
Loading