Skip to content

fix(fuselage): issues not caught by visual regression testing after Sass rewrite#1961

Merged
gabriellsh merged 4 commits into
mainfrom
regression/sass
May 8, 2026
Merged

fix(fuselage): issues not caught by visual regression testing after Sass rewrite#1961
gabriellsh merged 4 commits into
mainfrom
regression/sass

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented May 7, 2026

Proposed changes (including videos or screenshots)

It fixes issues in Avatar, Chip, and <a> elements.

Issue(s)

Further comments

@gabriellsh suggested my visual regression test was botched due to pixel diff tolerance getting bamboozled in large snapshots; he was right.

Introduced here #1765

@tassoevan tassoevan requested a review from a team May 7, 2026 20:47
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: 6f8b077

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tassoevan tassoevan changed the title regression(fuselage): issues not caught by visual regression testing after Sass rewrite fix(fuselage): issues not caught by visual regression testing after Sass rewrite May 8, 2026
gabriellsh
gabriellsh previously approved these changes May 8, 2026
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gabriellsh gabriellsh merged commit 792c038 into main May 8, 2026
8 checks passed
@gabriellsh gabriellsh deleted the regression/sass branch May 8, 2026 19:05
@github-actions github-actions Bot mentioned this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants