chore: remove npm-run-all dependency#1965
Open
tassoevan wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all
run-s(fromnpm-run-all) invocations with Yarn Berry's built-inruncommand chained with&&, then remove thenpm-run-alldevDependency from all 13 packages.What changed
package.jsonfiles: replacedrun-s .:script:a .:script:b→run .:script:a && run .:script:bpackage.jsonfiles: removed"npm-run-all": "^4.1.5"fromdevDependencies(includes 2 packages that had the dep but never used it:emitter,icons)yarn.lock: 26 transitive packages removedWhy
npm-run-allis unmaintained (last publish 2019) and unnecessary — Yarn Berry natively supportsrun <script>in shell commandsfuselage-formswas already using this pattern (run .:build:clean && run .:build:esm && run .:build:cjs)