-
Notifications
You must be signed in to change notification settings - Fork 1
Liftbau-3745: Upgrade to Spring 3 and Java 17 #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| api group: 'org.apache.velocity', name: 'velocity-engine-core', version: '2.0' | ||
|
|
||
| testCompile 'junit:junit:4.12' | ||
| api 'junit:junit:4.12' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inversion just has to use junit in the src code, doesn't it..... 😭
| if (field.getAnnotation(Ignore.class) != null || Modifier.isTransient(field.getModifiers())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with including org.springframework.boot:spring-boot-starter-test in the compile-time code.......... Which is where this junit4 dependencies was coming from prior to me upgrading the spring version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gross.
| compile 'org.springframework.boot:spring-boot-starter-jdbc' | ||
| compile 'org.springframework.boot:spring-boot-starter-test' | ||
| compile 'net.rakugakibox.spring.boot:logback-access-spring-boot-starter:2.6.0' | ||
| api "org.springframework.boot:spring-boot-starter-web:$springBootVersion" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this was copied from the same inversion upgrade we did for Snooze -> #180
(At some point, we really need to spend the time to get all our projects that use inversion to use the same version of inversion...............)
paul-eggerling-boeck-rp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming that Indexer is the only app using this version of Inversion?
Yeah, its the only active app that uses this version. The one-time-code repo uses it too, but that app was removed last year. Otherwise, snooze, heartbeat and token-tracker all use inversion 0.3.x |
https://circlek.atlassian.net/browse/LIFTBAU-3745