This repository was archived by the owner on Oct 11, 2026. It is now read-only.
Repository navigation
fix(analytics): close EI Regeneration buffUptimes parity - #117
Merged
Merged
Conversation
Owner
Author
|
reopening to trigger pull_request CI |
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
force-pushed
the
fix/regen-buffuptime-parity
branch
from
August 4, 2026 11:18
f322cd2 to
eeede7e
Compare
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Diff de parité sur
players.buffUptimes[718].uptime(Regeneration) vs Elite Insights, jusqu'à 11 logs concernés.Cause racine
Le simulateur regen de
BuffStateTrackerne répliquait pasBuffSimulatorDuration+HealingLogic(capacity 5) :stacks.Last()d'EI),added_active/no_sort+ move-to-front) câblée uniquement surBuffStackActiveEvent, qui ne se déclenche pas sur les logs 2025 — le flag arrive par-apply viais_shields.Changements
models.py: champadded_activesurBoonApplyEventparser.py: propageis_shields→added_active(chemin non-statechange 2025)buff_state.py: branche regen = queue cap-5, replaceLast()au overflow, heal-sort, activation EIVérification
Port exact validé contre les logs test 3089/3232 (bar 44.757 / 43.852 = EI). Reste 1 diff ouvert (joueur 9365, 52.751 vs 52.791).