Skip to content
This repository was archived by the owner on Oct 11, 2026. It is now read-only.

fix(analytics): close EI Regeneration buffUptimes parity - #117

Merged
Roddygithub merged 11 commits into
mainfrom
fix/regen-buffuptime-parity
Aug 4, 2026
Merged

Roddygithub merged 11 commits into
mainfrom
fix/regen-buffuptime-parity

Conversation

@Roddygithub

Copy link
Copy Markdown
Owner

Problème

Diff de parité sur players.buffUptimes[718].uptime (Regeneration) vs Elite Insights, jusqu'à 11 logs concernés.

Cause racine

Le simulateur regen de BuffStateTracker ne répliquait pas BuffSimulatorDuration + HealingLogic (capacity 5) :

  1. overflow → drop du nouveau item au lieu du plus vieux stack (remplacement stacks.Last() d'EI),
  2. activation (added_active/no_sort + move-to-front) câblée uniquement sur BuffStackActiveEvent, qui ne se déclenche pas sur les logs 2025 — le flag arrive par-apply via is_shields.

Changements

  • models.py : champ added_active sur BoonApplyEvent
  • parser.py : propage is_shields → added_active (chemin non-statechange 2025)
  • buff_state.py : branche regen = queue cap-5, replace Last() au overflow, heal-sort, activation EI

Vérification

Port exact validé contre les logs test 3089/3232 (bar 44.757 / 43.852 = EI). Reste 1 diff ouvert (joueur 9365, 52.751 vs 52.791).

@Roddygithub

Copy link
Copy Markdown
Owner Author

reopening to trigger pull_request CI

@Roddygithub Roddygithub closed this Aug 4, 2026
@Roddygithub Roddygithub reopened this Aug 4, 2026
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
Roddygithub force-pushed the fix/regen-buffuptime-parity branch from f322cd2 to eeede7e Compare August 4, 2026 11:18
@Roddygithub
Roddygithub merged commit b1fb47b into main Aug 4, 2026
11 checks passed
@Roddygithub
Roddygithub deleted the fix/regen-buffuptime-parity branch August 4, 2026 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant