Skip to content

fix(rotation): reduce EI parser parity deltas - #203

Merged
Roddygithub merged 11 commits into
mainfrom
fix/rotation-next-after-202
Aug 9, 2026
Merged

fix(rotation): reduce EI parser parity deltas#203
Roddygithub merged 11 commits into
mainfrom
fix/rotation-next-after-202

Conversation

@Roddygithub

@Roddygithub Roddygithub commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • keep shared-instance EI buff uptimes separate and exclude breakbar from damage taken count
  • add targeted rotation gates/mappings for EI instant casts
  • improve parser/source handling for Blood Moon and split player agents

Verification

  • uv run pytest libs/gw2_analytics/tests -q
  • uv run ruff check libs/gw2_analytics/src/gw2_analytics/rotation.py libs/gw2_analytics/tests/test_rotation.py
  • uv run python scripts/ei-parity/ei_diff.py --json /tmp/opencode/ei_buff_alias_ids.json

Final parity: TOTAL 196 differences across 35 logs; rotation 62 casts missing / 121 extra; players.rotation 68.

@Roddygithub
fix(parser): keep Blood Moon on Stone Spirit caster
62cd85b 
EI does not resolve the owner of a Stone Spirit's Blood Moon (the
spirit is not a Druid), so the cast is not credited to the player.
Restrict the raw-caster behaviour to Blood Moon only; resolving the
owner globally broke Venomous Outburst, Rending Vines and Enveloping
Haze.

Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
fix(rotation): use expected duration for All In
8efe059 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
fix(ei): select split player agents by EI entry
8d64beb 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
fix(ei): exclude breakbar from damage taken count
8d4a4dd 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
fix(ei): keep shared-instance buff uptimes separate
f835e8e 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
fix(rotation): use expected durations for more pending casts
08ca551 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
fix(rotation): ignore inactive distortion shatter refreshes
ab2f639 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
fix(rotation): skip chronomancer mind wrack effect
cad51d8 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
fix(rotation): add more EI instant cast gates
f1f2261 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
Roddygithub force-pushed the fix/rotation-next-after-202 branch from 6cb5da0 to f1f2261 Compare August 9, 2026 13:34
@Roddygithub
fix(ei): remove unused instance id local
6767418 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
style(parser): format blood moon parser test
abdedf1 
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
@Roddygithub
Roddygithub merged commit f45df81 into main Aug 9, 2026
11 checks passed
@Roddygithub
Roddygithub deleted the fix/rotation-next-after-202 branch August 9, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Roddygithub