Repository navigation
fix(parser): treat is_offcycle buff records as extensions, graft onto closest stack - #206
Merged
Merged
Conversation
… hits EI books a breakbar-only skill as interrupted (connectedHits = 0) when the player interrupted an enemy cast with that skill, instead of counting the result-10 ticks. Skip breakbar-only counting for skills with a matching InterruptEvent from the same source within the slice. Verified across the 35-log corpus: the two remaining connectedHits diffs (skills 5930 / 12621 on 20260508-001302) are the only such cases, and the new rule clears both without touching any other log. Parity 179 -> 177. Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
force-pushed
the
fix/parser-parity-after-179
branch
from
August 10, 2026 00:55
c5f9dd8 to
4f639de
Compare
Roddygithub
changed the title
Roddygithub
force-pushed
the
fix/parser-parity-after-179
branch
from
August 10, 2026 00:59
4f639de to
aa644a0
Compare
… closest stack EI converts arcdps buff records with is_offcycle != 0 (a refresh on a living stack) into BuffExtensionEvent that adds duration to the existing stack closest to oldValue, without consuming a slot or evicting. The tracker was emitting them as fresh BoonApplyEvents that got evicted at the 25-stack cap, losing ~0.8 average might stacks vs EI (11.24 vs 12.07 on the 2026-03-09 log). - parser: emit BuffExtensionEvent(extended=value, new=overstack) for is_offcycle applies, mirroring the statechange-70 path. - buff_state: _process_buff_extension now grafts onto the stack closest to old_duration (EI MinBy(|TotalDuration - oldValue|)) instead of the shortest expiry. Uptime 11.241 -> 11.771. Parser tests 188 passed, buff_state 32 passed. Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
force-pushed
the
fix/parser-parity-after-179
branch
from
August 10, 2026 01:03
aa644a0 to
c55fea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ce que contient le PR (2 commits)
is_offcycle != 0(refresh sur stack vivante) sont émis enBuffExtensionEvent(miroir du chemin statechange-70) et greffés sur la stack la plus proche deold_duration(règle EIMinBy(|TotalDuration − oldValue|)).Résultat (commit parser)
Parser : 65 applies + 31 extensions (avant 96 applies). Uptime might 11.241 → 11.771 sur le log 2026-03-09 (EI : 12.07). Tests : 188 parser + 32 buff_state au vert.
Notes
buff_dmg>0+OffsetNewDuration) — séparé.