Repository navigation
fix: EI down-contribution parity + awareness scan exclusions - #207
Merged
Merged
Conversation
Elite Insights' IsDownedBeforeNext90 treats a hit delivered before the target's first HealthUpdate as hitting at unknown HP (<=90%), so the pre-down window must open right after the last rally even without a health reading. Parity regression on 20260213-213832: 503 vs 267. Signed-off-by: Roland Salardon <r.salardon@gmail.com>
…ness scan These statechange kinds can reference a stale agent id after that agent despawned (druid heal on merged minion raw id, swiftness/protection stack ticks on despawned minion ids), overcounting boon uptime on every combined-player minion. EI truncates awareness at despawn+10. Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
force-pushed
the
fix/down-contribution-parity
branch
from
August 11, 2026 00:28
e4c5bae to
e1233ef
Compare
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
down-contribution parity (65341f8)
Open the pre-down window before the first HealthUpdate. EI's
IsDownedBeforeNext90treats a hit at unknown HP (no HealthUpdate yet) as <=90%, so damage before the first reading must count. Parity regression 20260213-213832: 503 vs 267.awareness scan exclusions (e4c5bae)
Exclude HealthUpdate (8) / StackActive (27) statechanges from
scan_agent_awareness— they can reference stale despawned agent ids, overcounting boon uptime on combined-player minions. EI truncates awareness at despawn+10.Both packages' full test suites + ruff pass.