This repository was archived by the owner on Oct 11, 2026. It is now read-only.
Repository navigation
fix(ei-compare): reach full parity on ranger pet spawns (-28) - #209
Merged
Merged
Conversation
Elite Insights credits the -28 "Ranger Pet Spawned" rotation entry only
for minions whose species is in its static JuvenilePetIDs list (65
species) AND whose master relationship was resolved (activeRangerPets !=
null). Two fixes bring parity to 0 missing / 0 extra across the 35-log
corpus (was 2 missing / 11 extra):
- Replace the name-based juvenile-pet filter (which wrongly included
the phoenix 25131, absent from EI's list) with the exact
_JUVENILE_PET_SPECIES whitelist mirrored from RangerHelper.cs.
- Gate -28 casts on player.get("activeRangerPets") being non-null,
mirroring EI's MinionSpawnCastFinder which requires m.Master != null.
- Keep -28 casts that land within 2000ms before slice_lo, matching EI's
time-slice tolerance.
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objectif
Parité 100 % avec Elite Insights sur le skill rotation
-28("Ranger Pet Spawned") : 0 missing / 0 extra sur les 35 logs (avant : 2 missing / 11 extra).Changements (
libs/gw2_analytics/src/gw2_analytics/ei_compare.py)_JUVENILE_PET_SPECIES(65 espèces) — miroir exact deRangerHelper.JuvenilePetIDsd'EI, remplace le filtre par nom qui incluait à tort le phénix (25131, absent de la liste EI).-28suractiveRangerPets != null— EI ne crédite un-28que si la relation master/minion est résolue (m.Master != null). Élimine les 11 extra (char-swap / instances partagées).slice_lopour les casts-28, aligné sur le comportement de slicing d'EI. Corrige les 2 missing.Vérification
-28absent des deltas rotation.pytest libs/gw2_analytics: 326 passed.Signed-off-by).