Repository navigation
fix(ei-compare): slice-aware agent IDs for stats - #228
Merged
Merged
Conversation
- buffUptimes: pass slice_lo/slice_hi to player_agent_ids() for instance recycling (175 -> 53 FAILs, -70%) - stats: use player_agent_ids(agent, slice_lo, slice_hi) instead of static agent_ids_by_instance for damage/CC/down filtering - rotation: peer gate for 71356/13980, 5780 ICD 900ms (52 -> 49 diffs) Known limitations (deferred): - 6 group diffs: WvW squad detection needs EVTC squad data - 23 stats diffs: downContribution/CC slice matching - 8 rotation: 71356/13980 1st-heal edge cases Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
marked this pull request as ready for review
August 15, 2026 13:21
…ent test) The slice-aware agent_ids for stats broke the anonymous agent test (test_compare_elite_insights_keeps_first_anonymous_agent_for_shared_instance). Revert to static agent_ids_by_instance for stats; keep buffUptimes fix. Known limitations unchanged: - 23 stats diffs (downContribution/CC) - 6 group diffs (WvW squad detection) - 8 rotation 71356/13980 edge cases Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert stats slice-aware change (broke anonymous agent test). Keep buffUptimes fix from PR #227. Known: 23 stats diffs, 6 group diffs, 8 rotation edge cases.