Skip to content

fix(rotation): add missing finders + fix duplicate key #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roddygithub merged 3 commits into from
Aug 15, 2026
Merged

fix(rotation): add missing finders + fix duplicate key #233

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45d79d4
fix(rotation): add missing finders for Shale Storm, Relic of Sorrow, …
Roddygithub Aug 15, 2026
8319b1b
fix(rotation): fix duplicate key 22499 in _DAMAGE_CASTS dict
Roddygithub Aug 15, 2026
a405c3e
style(rotation): ruff format
Roddygithub Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion libs/gw2_analytics/src/gw2_analytics/rotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@
9123: 9082, # Shield of Wrath
10582: 10583, # Spectral Armor
62919: 62749, # Legendary Alliance Stance
72996: 72906, # Shale Storm buff -> Shale Storm skill
79373: 72906, # Shale Storm Secondary Attack buff -> Shale Storm skill
}
_BUFF_LOSS_CASTS = {
29446: 30961,
Expand Down Expand Up @@ -335,6 +337,10 @@
"13D0B65D73B5334D80824EE17B5C257E": 13677,
"FB78801BB31CAF488B55F2F57EF9B070": 78837,
"842F977C318FDC4F96C99C385C1D0672": 76613, # Symbiotic Shielding
"3D981397D9C6A44B888212CE4E3F6F9A": 74410, # Relic of Sorrow
"DB02EB39ABBEE241859DC9662AD49FA5": 74410, # Relic of Sorrow
"FEEA4632BAF0B1438D83F6C8B71AEA15": 74410, # Relic of Sorrow
"8D36806A690A5442A983308EDCECB018": 63195, # Unnatural Traversal
"4A83F0B627B75C47894941C4D35BA89F": 78604,
"03850757F14FD44A9998D4CAD71CC589": 78358,
"611D90C69ECF8142BEEE84139F333388": 30101,
Expand Down Expand Up @@ -462,8 +468,9 @@
"23284B87C26C9A41A887F410F930E1A2": 13064, # Infiltrator's Signet
"BB5488951B60B546BB1BD5626DAE83E1": 13062, # Signet of Agility
"418A090D719AB44AAF1C4AD1473068C4": 43176, # Flash Spark
"D7F8FA5695F8714B99A51EE72EF6E178": 14413, # Dolyak Signet
"D7F8FA5695F8714B99A5C3EE72EF6E178": 14413, # Dolyak Signet
"68F2C378E6C80548B5A3C89870C5DD86": 9085, # "Save Yourselves!"
"8D36806A690A5442A983308EDCECB018": 63195, # Unnatural Traversal
}
_SECONDARY_EFFECTS = {
_MECHANIST_SHIFT_SIGNET_EFFECT: (_MECHANIST_SHIFT_SIGNET_SELF_EFFECT,),
Expand Down
Loading