This repository was archived by the owner on Oct 11, 2026. It is now read-only.
Repository navigation
fix(rotation): implement proper Spiteful Spirit (29560) finder logic (v2) - #235
Merged
Merged
Conversation
- Implement both EI finder paths: 1. DamageCastFinder: disabled when UnholyBurst effect data exists (UsingDisableWithEffectData) 2. EffectCastFinder for UnholyBurst: triggers on effect with DesertShroud/related hit checks - Add DesertShroud buff removal check (skill 40052, 50ms window) - Add related UnholyBurst hit check (skill 38767, 10ms window) - Increase UnholyBurst proximity window to 100ms (was 50ms) to catch early casts Fixes 31 Spiteful Spirit FAILs across corpus. Signed-off-by: Roland Salardon <r.salardon@gmail.com>
…Unnatural Traversal, Shattered Aegis - Shale Storm (72906): BuffGainCastFinder for ShaleStormBuff (72996) and ShaleStormSecondaryAttackBuff (79373) - Relic of Sorrow (74410): EffectCastFinder with RelicOfSorrow1/2/3 effect GUIDs - Unnatural Traversal (63195): EffectCastFinderByDst with UntamedUnnaturalTraversal effect GUID - Shattered Aegis (22499): DamageCastFinder with 50ms ICD These address missing rotation casts in the corpus. Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
marked this pull request as ready for review
August 15, 2026 22:06
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
force-pushed
the
fix/spiteful-spirit-fix-v2
branch
from
August 15, 2026 22:17
f3c7856 to
733293b
Compare
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements proper EI finder logic for Spiteful Spirit (29560):
Fixes 31 Spiteful Spirit FAILs across corpus.