This repository was archived by the owner on Oct 11, 2026. It is now read-only.
Repository navigation
fix(rotation): fix Spiteful Spirit (29560) over-generation - #236
Merged
Merged
Conversation
…ng DamageCastFinder when UnholyBurst effect exists - Per EI: DamageCastFinder disabled when effect data exists (UsingDisableWithEffectData) - Only emit via EffectCastFinder on UnholyBurst effect with DesertShroud/related hit checks - Fixes 31 Spiteful Spirit FAILs (over-generation) Signed-off-by: Roland Salardon <r.salardon@gmail.com>
Roddygithub
marked this pull request as ready for review
August 15, 2026 22:56
Signed-off-by: Roland Salardon <r.salardon@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Spiteful Spirit (29560) over-generation by disabling DamageCastFinder when UnholyBurst effect exists globally, per EI's UsingDisableWithEffectData.